UNOMI-937: Diagnostic fixes that missed the merge window#765
Merged
Conversation
The keepTrying supplier caught all exceptions silently and returned null, so when polling timed out CI only showed the generic message with no root cause. Now we log e.getMessage() at WARN on each failed attempt so connection errors and parse failures are visible in CI logs.
… on version detection failure build.sh: handle_error was stripped of the failing command to avoid hitting ARG_MAX when $BASH_COMMAND expanded to a large mvn invocation. Reading BASH_COMMAND inside the function (instead of passing it through the trap) sidesteps the ARG_MAX issue while still printing the first 200 characters of the failing command, making CI failure triage easier. setenv.sh: mvn stderr was redirected to /dev/null to avoid capturing download noise into UNOMI_VERSION. On failure this silently discarded the actual error message. Stderr is now captured to a temp file and printed to stderr if version detection fails.
…te, not inside handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small diagnostic improvements committed to the local
UNOMI-937-itests-hardening-cibranch after the PR was merged on GitHub, so they never landed in master.GraphQLListIT.java: AddLOGGER.warn(e.getMessage())inside thekeepTryingpoll supplier so failed HTTP attempts are visible in CI logs instead of timing out silently.build.sh: Restore the failing command inhandle_erroroutput by reading$BASH_COMMANDinside the function (avoids ARG_MAX) and printing the first 200 chars.setenv.sh: Capture Maven stderr to a temp file instead of2>/dev/nullso version detection failures print the actual error.These were committed in response to Copilot review comments on #764 but were not pushed before the branch was merged and deleted.