[CPP_RPC] Replace legacy OS-specific API with std:: libraries#19840
[CPP_RPC] Replace legacy OS-specific API with std:: libraries#19840cbalint13 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request modernizes the C++ RPC server by refactoring file system operations to use C++17 <filesystem> and replacing the double-fork watchdog mechanism with a cleaner thread-based watchdog. Feedback focuses on critical security and robustness improvements: restricting directory permissions from world-writable (0777) to owner-only (0700) to prevent local privilege escalation, resolving a potential race condition where a recycled PID could be killed by the watchdog thread, and using the std::error_code overload of std::filesystem::create_directories to avoid potential crashes from unhandled exceptions.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
35e3f85 to
223e64b
Compare
9caf5bc to
f1c9fb9
Compare
Replaces OS dependent API with standard cpp libraries in the
tvm_rpctool.Currently tested with real tuning processes but limited to linux machines.