[Relax][PyTorch] Add rnn_tanh.input converter#19837
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds support for translating vanilla tanh-RNN cells (_rnn_tanh and _rnn_tanh_cell_unroll) in the TVM Relax PyTorch frontend. The review feedback identifies three critical issues: a typo in the function call premute_dims instead of permute_dims, an incorrect range definition for the reverse path iteration that lacks a step argument, and an incorrect initialization of the forward hidden state using zeros instead of slicing the input hidden state hx with take.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
78f1250 to
4cebdbd
Compare
Hi Committers,
This PR addresses the
rnn_tanh.inputpart of issue #18364. Any suggestions would be appreciated if you are available.