Fixed build error and warnings when building VTA_TSIM with TVM#39
Open
k0nze wants to merge 1 commit intoapache:mainfrom
Open
Fixed build error and warnings when building VTA_TSIM with TVM#39k0nze wants to merge 1 commit intoapache:mainfrom
k0nze wants to merge 1 commit intoapache:mainfrom
Conversation
…ule.cc) to fix inheritance error when building VTA_TSIM with TVM and added override statements to DPIModule methods that override methods of the base class DPIModuleNode.
Contributor
|
Good catch, and looks like this was introduced by apache/tvm#14902 may in May. |
Author
|
Are there plans to merge this PR and #38? |
Contributor
|
Unfortunately, I don't have commit privs for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building VTA_TSIM from TVM, an error occurred, which was fixed by changing the signature of
DPIModule(src/dpi/module.cc) fromstd::stringtotvm::runtime::String. Additionally,overridestatements were added toDPIModulemethods which override virtual methods ofDPIModuleNode(src/dpi/module.h) to get rid of warnings when building VTA_TSIM.