Skip to content

[to dev/1.1] fix GroupByMonthFilter.getTimeRanges #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JackieTien97 merged 1 commit into from
Oct 25, 2025
Merged

[to dev/1.1] fix GroupByMonthFilter.getTimeRanges #610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions java/tsfile/src/main/java/org/apache/tsfile/read/filter/operator/GroupByMonthFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

package org.apache.tsfile.read.filter.operator;

import org.apache.tsfile.read.common.TimeRange;
import org.apache.tsfile.read.filter.basic.Filter;
import org.apache.tsfile.read.filter.basic.OperatorType;
import org.apache.tsfile.utils.ReadWriteIOUtils;
Expand All @@ -29,6 +30,8 @@
import java.nio.ByteBuffer;
import java.util.Arrays;
import java.util.Calendar;
import java.util.Collections;
import java.util.List;
import java.util.Objects;
import java.util.TimeZone;
import java.util.concurrent.TimeUnit;
Expand Down Expand Up @@ -139,6 +142,14 @@ public boolean containStartEndTime(long startTime, long endTime) {
}
}

@Override
public List<TimeRange> getTimeRanges() {
// this.startTime will be modified dynamically
return originalStartTime >= originalEndTime
? Collections.emptyList()
: Collections.singletonList(new TimeRange(originalStartTime, originalEndTime - 1));
}

private boolean isContainedByCurrentInterval(long startTime, long endTime) {
if (startTime < this.startTime || endTime > this.endTime) {
return false;
Expand Down