Address incompatibility with BoringSSL#12943
Open
maskit wants to merge 1 commit intoapache:masterfrom
Open
Conversation
BoringSSL recently moved some data types and functions into bssl namespace.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses build failures against newer BoringSSL where some ASN.1 types/symbols have moved under the bssl namespace.
Changes:
- Add a CMake compile-check to detect whether
GENERAL_NAMElives in thebsslnamespace. - Plumb the new
HAVE_GENERAL_NAME_IN_BSSL_NAMESPACEdefine into the generated config header. - Conditionally qualify
GENERAL_NAMEusage in OCSP stapling ASN.1 templates.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/iocore/net/OCSPStapling.cc |
Uses HAVE_GENERAL_NAME_IN_BSSL_NAMESPACE to adjust ASN.1 declarations/usages for OCSP stapling. |
include/tscore/ink_config.h.cmake.in |
Adds the new HAVE_GENERAL_NAME_IN_BSSL_NAMESPACE config define. |
CMakeLists.txt |
Introduces the feature-detection compile check that drives HAVE_GENERAL_NAME_IN_BSSL_NAMESPACE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BoringSSL recently moved some data types and functions into bssl namespace. That caused build errors.