Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@ocket8888
Copy link
Contributor

Closes #2856

This PR adds context menu options to the servers table in TPv2 that allow for quick and easy queuing/dequeuing revalidations on a group of one or more servers.

I also plugged a testing gap in the servers API service - Capability-related methods were untested.


Which Traffic Control components are affected by this PR?

  • Traffic Portal (experimental v2)

What is the best way to verify this PR?

Make sure the provided e2e and unit tests pass. Queue/Dequeue updates on some server(s).

PR submission checklist

  • This PR has tests
  • This PR doesn't need documentation
  • This PR doesn't need a CHANGELOG.md entry
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added new feature A new feature, capability or behavior low impact affects only a small portion of a CDN, and cannot itself break one experimental a feature/component not directly supported by ATC Traffic Portal v2 Related to the experimental Traffic Portal version 2 labels Jan 23, 2024
@codecov
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

❌ Patch coverage is 57.14286% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.73%. Comparing base (0b802b5) to head (bf9d673).
⚠️ Report is 148 commits behind head on master.

Files with missing lines Patch % Lines
...affic-portal/src/app/api/testing/server.service.ts 0.00% 12 Missing ⚠️
...e/servers/servers-table/servers-table.component.ts 80.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #7923      +/-   ##
============================================
+ Coverage     65.65%   65.73%   +0.07%     
  Complexity       98       98              
============================================
  Files           323      323              
  Lines         12840    12863      +23     
  Branches        970      975       +5     
============================================
+ Hits           8430     8455      +25     
+ Misses         4050     4048       -2     
  Partials        360      360              
Flag Coverage Δ
traffic_portal_v2 ∅ <57.14%> (∅)
unit_tests ∅ <57.14%> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ocket8888
Copy link
Contributor Author

Depends on #7925

@ocket8888 ocket8888 marked this pull request as draft January 23, 2024 20:38
@ocket8888 ocket8888 marked this pull request as ready for review January 23, 2024 23:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

experimental a feature/component not directly supported by ATC low impact affects only a small portion of a CDN, and cannot itself break one new feature A new feature, capability or behavior Traffic Portal v2 Related to the experimental Traffic Portal version 2

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

Add the ability to trigger a global reval on all caches for a given CDN

1 participant