Refactor ECDH curve name extraction to avoid deprecated methods#34
Merged
Refactor ECDH curve name extraction to avoid deprecated methods#34
Conversation
|
Typo in the changelog: "Refcator" -> "Refactor". |
Contributor
Author
Thanks. Fixed. |
Contributor
Author
|
Through local testing I have been able to confirm that the new code behaves in the same way as the old so I am going to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Providing this as a pull request to give folks a chance to review it.
I wrote this with the help of AI (GitHub CoPilot) to identify possible alternative approaches to the deprecated methods. The result looks reasonable and the new calls look to be doing the right thing but I'd like more eyes on this before committing.