TINKERPOP-3233 Go support for escaped characters#3381
Open
GumpacG wants to merge 1 commit intoapache:masterfrom
Open
TINKERPOP-3233 Go support for escaped characters#3381GumpacG wants to merge 1 commit intoapache:masterfrom
GumpacG wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3381 +/- ##
============================================
- Coverage 77.87% 76.25% -1.63%
+ Complexity 13578 13313 -265
============================================
Files 1015 1011 -4
Lines 59308 59832 +524
Branches 6835 7004 +169
============================================
- Hits 46184 45622 -562
- Misses 10817 11527 +710
- Partials 2307 2683 +376 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Cole-Greer
reviewed
Apr 9, 2026
Comment on lines
+679
to
+681
| return g.V().Has("name", "\"marko\n\r\t\b\f\"") | ||
| }, | ||
| equals: "g.V().has(\"name\",\"\\\"marko\\n\\r\\t\\b\\f\\\"\")", |
Contributor
There was a problem hiding this comment.
Nit: Throw a single quote in there too
Suggested change
| return g.V().Has("name", "\"marko\n\r\t\b\f\"") | |
| }, | |
| equals: "g.V().has(\"name\",\"\\\"marko\\n\\r\\t\\b\\f\\\"\")", | |
| return g.V().Has("name", "\"marko\n\r\t\b\f\'") | |
| }, | |
| equals: "g.V().has(\"name\",\"\\\"marko\\n\\r\\t\\b\\f\\\'\")", |
Contributor
|
Thanks @GumpacG, LGTM. VOTE +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-3233
This is the first part of resolving the ticket.
This change fixes a bug in Go in which characters that should be escaped are being replaced by a dot.
Bug:
The traversal
result, err := g.V().Has(vertexLabel, "name", "m m").Next()would generate the GremlinLangg.V().has(vertexLabel, "name", "m.m").next().New behaviour:
The traversal
result, err := g.V().Has(vertexLabel, "name", "m m").Next()would generate the GremlinLangg.V().has(vertexLabel, "name", "m\tm").next().A test has been added to
gremlinlang_test.gofor testing all cases that should be escaped.