-
Notifications
You must be signed in to change notification settings - Fork 847
Integrate Java driver examples into automated build process #3297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kirill-stepanishin
wants to merge
2
commits into
apache:3.7-dev
Choose a base branch
from
kirill-stepanishin:java-examples-CI-integration
base: 3.7-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77 changes: 77 additions & 0 deletions
77
...server/src/test/java/org/apache/tinkerpop/gremlin/driver/DriverExamplesIntegrateTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.tinkerpop.gremlin.driver; | ||
|
|
||
| import examples.BasicGremlin; | ||
| import examples.Connections; | ||
| import examples.ModernTraversals; | ||
| import org.apache.tinkerpop.gremlin.server.AbstractGremlinServerIntegrationTest; | ||
| import org.junit.AfterClass; | ||
| import org.junit.BeforeClass; | ||
| import org.junit.Test; | ||
|
|
||
| import static org.junit.Assert.fail; | ||
|
|
||
| /** | ||
| * Integration tests for driver examples to ensure they work with the current driver. | ||
| * These tests catch breaking changes that would affect example code. | ||
| */ | ||
| public class DriverExamplesIntegrateTest extends AbstractGremlinServerIntegrationTest { | ||
|
|
||
| @BeforeClass | ||
| public static void setUpEnvironment() { | ||
| // Set environment variables for examples to connect to test server | ||
| System.setProperty("GREMLIN_SERVER_HOST", "localhost"); | ||
| System.setProperty("GREMLIN_SERVER_PORT", "45940"); | ||
| } | ||
|
|
||
| @AfterClass | ||
| public static void tearDownEnvironment() { | ||
| // Clean up system properties | ||
| System.clearProperty("GREMLIN_SERVER_HOST"); | ||
| System.clearProperty("GREMLIN_SERVER_PORT"); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldRunBasicGremlinExample() throws Exception { | ||
| try { | ||
| BasicGremlin.main(new String[]{}); | ||
| } catch (Exception e) { | ||
| fail("BasicGremlin example failed: " + e.getMessage()); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldRunModernTraversalsExample() throws Exception { | ||
| try { | ||
| ModernTraversals.main(new String[]{}); | ||
| } catch (Exception e) { | ||
| fail("ModernTraversals example failed: " + e.getMessage()); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldRunConnectionsExample() throws Exception { | ||
| try { | ||
| Connections.main(new String[]{}); | ||
| } catch (Exception e) { | ||
| fail("Connections example failed: " + e.getMessage()); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit odd to me that this file runs the main function of other classes. I know those classes are there to mimic the ones from gremlin-examples, but seeing as how this is going to be tied to integration test, you might as well just make each of those classes a test in this file instead? Just a thought, doesn't really need to be changed if you feel that it makes more sense this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that making the examples complete tests makes more sense in this isolated context. It's done more to mimic the rest of the GLVs, where currently the examples are also simply executed as part of the integration tests. Perhaps adding output validation and converting examples into proper tests could be a future piece of work.
As of now, I think it makes sense to keep the current approach to stay consistent with the other GLVs, and the main goal of catching the breaking changes that affect examples is still achieved.