TINKERPOP-3217 Add server option to close Session automatically. #3284
Conversation
...-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/session/SessionOpProcessor.java
Show resolved
Hide resolved
...er/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinSessionReuseTxIntegrateTest.java
Outdated
Show resolved
Hide resolved
...er/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinSessionReuseTxIntegrateTest.java
Outdated
Show resolved
Hide resolved
| if (destroySessionPostGraphOp) { | ||
| // Destroy the session after a successful rollback due to error. Placed here rather than | ||
| // in a finally block since we don't want to end the session if no commit/rollback succeeded. | ||
| session.manualKill(true); |
There was a problem hiding this comment.
Since this is in a catch block that is catching all error types, is it possible for session.manualKill to be called twice if the previous call in the try block threw an error?
There was a problem hiding this comment.
This shouldn't happen, but even if it does, theres explicit handling in that method for that situation so it's safe to call it more than once.
...er/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinSessionReuseTxIntegrateTest.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * Integration tests for gremlin-driver and bytecode sessions. | ||
| * | ||
| * NOTE: this is effectively a copy of GremlinSessionTxIntegrateTest but the expectation is that the gremlin-driver |
There was a problem hiding this comment.
Is there a way to actually verify the connection is reused or the connection state such that it can be reused?
There was a problem hiding this comment.
There are server side metrics and/or logs that can be asserted against when a session is created/destroyed. This is a test that should be added but needs to wait on #3258
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/Settings.java
Outdated
Show resolved
Hide resolved
...er/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinSessionReuseTxIntegrateTest.java
Outdated
Show resolved
Hide resolved
...er/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinSessionReuseTxIntegrateTest.java
Outdated
Show resolved
Hide resolved
The added destroySessionPostGraphOp setting enables re-using the same underlying connection for a different subsequent Session. This should increase performance for cases where many short-lived Transactions are sent to the server.
kenhuuu
force-pushed
the
TINKERPOP-3217
branch
from
0d65b6f to
7f7d9b8
Compare
|
VOTE +1 |
1 similar comment
|
VOTE +1 |
|
Thank you, @kenhuuu, nice feature. Will port to our version too. |
FYI, @andrii0lomakin there is no released Java driver/GLV that can take advantage of this. This will change in the next version of TinkerPop. |
|
@kenhuuu we use our own fork, so we can use it already now. |
5 participants
The added destroySessionPostGraphOp setting enables re-using the same underlying connection for a different subsequent Session. This should increase performance for cases where many short-lived Transactions are sent to the server.
https://issues.apache.org/jira/browse/TINKERPOP-3217
VOTE +1