TEZ-4617 prevent resource leaks for Closeables #402
+219
−212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
abstractdog
reviewed
Jan 16, 2026
| @SuppressWarnings("deprecation") | ||
| public int run(String[] args) throws Exception { | ||
| Configuration conf = getConf(); | ||
| JobClient client = new JobClient(conf); |
Contributor
There was a problem hiding this comment.
would it make sense to refactor the method to use the JobClient to prevent many indentation, like:
try (JobClient client = new JobClient(conf))
run(client)
}
private run (JobClient client) {
}
abstractdog
reviewed
Jan 16, 2026
| Class.forName(args[++i]).asSubclass(OutputFormat.class); | ||
| } else { | ||
| otherArgs.add(args[i]); | ||
| try (JobClient client = new JobClient(conf)) { |
abstractdog
reviewed
Jan 16, 2026
| conf.setLong(BYTES_PER_MAP, totalBytesToWrite); | ||
| } | ||
| conf.setInt(MRJobConfig.NUM_MAPS, numMaps); | ||
| try (JobClient client = new JobClient(conf)) { |
abstractdog
reviewed
Jan 16, 2026
| pw.write("<script type='text/javascript'>setTimeout(function() { " + | ||
| "window.location.replace('" + historyUrl + "');" + | ||
| "}, 0); </script>"); | ||
| try(PrintWriter pw = writer()) { |
abstractdog
reviewed
Jan 16, 2026
| @Override | ||
| public void render() { | ||
| response().setContentType(MimeType.HTML); | ||
| PrintWriter pw = writer(); |
Contributor
There was a problem hiding this comment.
what about a separate method like:
try (PrintWriter pw = writer()) {
render(pw);
}
Contributor
|
thanks for this patch @dk2k, left some comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.