[SYSTEMDS-3948] Row-wise Sparsity Estimator#2466
[SYSTEMDS-3948] Row-wise Sparsity Estimator#2466ywcb00 wants to merge 10 commits intoapache:mainfrom
Conversation
Baunsgaard
left a comment
There was a problem hiding this comment.
Some comments. hope it helps.
| } | ||
|
|
||
|
|
||
| // Row Wise Sparsity Estimator |
There was a problem hiding this comment.
You can optionally have all of these classes extend another class where you add these tests. Instead of copying the code on all of them.
There was a problem hiding this comment.
Thank you for the comment. I do not fully understand how you would consolidate them. Could you please clarify?
There was a problem hiding this comment.
What I ment was something like :
OpElemWTest extends OpElemBaseTest {
}
and then you define a new OpElemBaseTest class that contains the variables all the different OpElem test cases share, and define in that base test the fundamental tests that all of the OpElem should run.
I hope this would work nicely, since it makes it easy to make the same test flavour run in all of the variations.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2466 +/- ##
============================================
+ Coverage 71.29% 71.34% +0.04%
- Complexity 48574 48686 +112
============================================
Files 1567 1569 +2
Lines 188401 188776 +375
Branches 36980 37040 +60
============================================
+ Hits 134325 134673 +348
+ Misses 43630 43628 -2
- Partials 10446 10475 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ise sparsity estimator works for the matrix multiplication and bind test cases for now
…to the unity tests for sparsity estimation
…ontainer for row wise sparsity vectors to simplify access and allow storing it with chain nodes
…mator with element-wise and single operations
…wise and single operations NOTE: using average case estimation per row
…ion for diagonal operation
…ro and diag (mv and vm) operations with the row-wise sparsity estimator
… to consolidate all calls to getters before the switch
… for row-wise sparsity vector and apply the corresponding operations directly in the code instead
30b1f54 to
2361593
Compare
Hi,
this PR adds the row-wise sparsity estimator from:
Lin, Chunxu, Wensheng Luo, Yixiang Fang, Chenhao Ma, Xilin Liu and Yuchi Ma;
On Efficient Large Sparse Matrix Chain Multiplication;
Proceedings of the ACM on Management of Data 2 (2024): 1 - 27.
Note that the row sparsity propagation, as described in the publication, applies to MM chains only. Other operations use fallback methods for sparsity estimation w/ row sparsity vectors, which create a cut in the sparsity estimation DAG.