Skip to content

[SYSTEMDS-3898] Add regression tests for quantile averaging on even-length inputs #2382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lumos07 wants to merge 2 commits into
base: main
Choose a base branch
from
+25 −23
Open

[SYSTEMDS-3898] Add regression tests for quantile averaging on even-length inputs #2382

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2e8643
Fix SYSTEMDS-3898: ensure quantile VALUEPICK computes output for non-…
Dec 12, 2025
01546c8
Fix SYSTEMDS-3898: ensure quantile VALUEPICK computes output for non-…
Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 25 additions & 23 deletions src/main/java/org/apache/sysds/runtime/instructions/cp/QuantilePickCPInstruction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,31 +83,33 @@ else if( parts.length == 6 ) {
public void processInstruction(ExecutionContext ec) {
switch( _type )
{
case VALUEPICK:
if( _inmem ) //INMEM VALUEPICK
{
MatrixBlock matBlock = ec.getMatrixInput(input1.getName());
case VALUEPICK:
// Handle both in-memory and non-in-memory VALUEPICK by materializing
// the input matrix and invoking the pick routines. Previously only
// the in-memory branch was executed which left the output unset
// when _inmem==false (see SYSTEMDS-3898).
{
MatrixBlock matBlock = ec.getMatrixInput(input1.getName());

if ( input2.getDataType() == DataType.SCALAR ) {
ScalarObject quantile = ec.getScalarInput(input2);
//pick value w/ explicit averaging for even-length arrays
double picked = matBlock.pickValue(
quantile.getDoubleValue(), matBlock.getLength()%2==0);
ec.setScalarOutput(output.getName(), new DoubleObject(picked));
}
else {
MatrixBlock quantiles = ec.getMatrixInput(input2.getName());
//pick value w/ explicit averaging for even-length arrays
MatrixBlock resultBlock = matBlock.pickValues(
quantiles, new MatrixBlock(), matBlock.getLength()%2==0);
quantiles = null;
ec.releaseMatrixInput(input2.getName());
ec.setMatrixOutput(output.getName(), resultBlock);
}
ec.releaseMatrixInput(input1.getName());
if ( input2.getDataType() == DataType.SCALAR ) {
ScalarObject quantile = ec.getScalarInput(input2);
// pick value w/ explicit averaging for even-length arrays
double picked = matBlock.pickValue(
quantile.getDoubleValue(), matBlock.getLength()%2==0);
ec.setScalarOutput(output.getName(), new DoubleObject(picked));
}
else {
MatrixBlock quantiles = ec.getMatrixInput(input2.getName());
// pick values w/ explicit averaging for even-length arrays
MatrixBlock resultBlock = matBlock.pickValues(
quantiles, new MatrixBlock(), matBlock.getLength()%2==0);
quantiles = null;
ec.releaseMatrixInput(input2.getName());
ec.setMatrixOutput(output.getName(), resultBlock);
}
break;

ec.releaseMatrixInput(input1.getName());
}
break;
case MEDIAN:
if( _inmem ) //INMEM MEDIAN
{
Expand Down