Skip to content

Conversation

@e-strauss
Copy link
Contributor

@e-strauss e-strauss commented Dec 10, 2025

Changes

  • Refactored Py4jConverterUtilsTest.java from component/frame/array to component/utils
  • Added missing test cases for matrix conversion
  • Added new conversion for CSR matrices

@github-project-automation github-project-automation bot moved this to In Progress in SystemDS PR Queue Dec 10, 2025
@e-strauss e-strauss changed the title [Draft] Transfer scipy compressed matrices transfer to java runtime [Draft] Transfer scipy compressed matrices to java runtime Dec 10, 2025
@e-strauss
Copy link
Contributor Author

e-strauss commented Dec 10, 2025

@Baunsgaard @mboehm7 https://github.com/apache/systemds/blob/8de93a1f996348c260d48c1c29340d5a88005e6f/src/main/python/systemds/context/systemds_context.py#L772C4-L772C20

the naming "from_numpy" is misleading since we support now scipy compressed matrices as well
shall we rename it to something like "from_py_matrix", "from_array_like"?

We could also use something like "from_pydata" which merges the two separate methods from_numpy and from_pandas to single method, internally we could route to the corresponding handler based on the input instance type.

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.37%. Comparing base (0e8e966) to head (badc156).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2379      +/-   ##
============================================
+ Coverage     72.33%   72.37%   +0.04%     
- Complexity    47005    47034      +29     
============================================
  Files          1513     1513              
  Lines        178738   178761      +23     
  Branches      35079    35082       +3     
============================================
+ Hits         129283   129376      +93     
+ Misses        39677    39595      -82     
- Partials       9778     9790      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

1 participant