Extend SupportsCatalogOptions to allow migration from DSv1 file based data source#56617
Draft
johanl-db wants to merge 1 commit into
Draft
Extend SupportsCatalogOptions to allow migration from DSv1 file based data source#56617johanl-db wants to merge 1 commit into
johanl-db wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Extend
SupportsCatalogOptionDSv2 interface with:useCatalogResolution: dynamically toggles using the behavior offered bySupportsCatalogOption. Needed to have a migration path from file-based source (DSv1) to DSv2 + SupportsCatalogOption that's not just a static on/offfailIfTableDoesNotExist: whetherdf.write.format(<format>).mode("append"/"overwrite").save()should succeed when the table doesn't exist.Why are the changes needed?
Delta will be migrating from a file-based data source (DSv1) for path based accesses to DSv2 using
SupportsCatalogOption.Two blockers are present:
TableProviderextendingSupportsCatalogOptionsor not. it will be a dynamic decision based on a flag to provide a migration and possibility to disable the new behavior if needed.df.write.format(<format>).mode("append"/"overwrite").save()when the table doesn't exist yet and will create it. This behavior must be preserved.Does this PR introduce any user-facing change?
No
How was this patch tested?
Added tests in
SupportsCatalogOptionSuite