Skip to content

[SPARK-54203][SQL] Support TimeType in RowToColumnConverter #56613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaxGekk wants to merge 2 commits into
base: master
Choose a base branch
from
+26 −1
Open

[SPARK-54203][SQL] Support TimeType in RowToColumnConverter #56613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd529cf
[SPARK-54203][SQL] Support TimeType in RowToColumnConverter
MaxGekk Jun 19, 2026
b33694c
[SPARK-54203][SQL] Match concrete TimeType in RowToColumnConverter di…
MaxGekk Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/execution/Columnar.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,8 @@ private object RowToColumnConverter {
case ShortType => ShortConverter
case IntegerType | DateType | _: YearMonthIntervalType => IntConverter
case FloatType => FloatConverter
case LongType | TimestampType | TimestampNTZType | _: DayTimeIntervalType => LongConverter
case LongType | TimestampType | TimestampNTZType | _: DayTimeIntervalType | _: TimeType =>
LongConverter
case DoubleType => DoubleConverter
case StringType => StringConverter
case _: GeographyType | _: GeometryType => BinaryViewConverter
Expand Down
24 changes: 24 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/RowToColumnConverterSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,30 @@ class RowToColumnConverterSuite extends SparkFunSuite {
assert(vectors.head.getTimestampLTZNanos(2) === TimestampNanosVal.fromParts(200L, 1.toShort))
}

test("TimeType column roundtrip") {
Seq(0, 3, 6).foreach { precision =>
val schema = StructType(Seq(StructField("t", TimeType(precision))))
val values = Seq(0L, 12L * 60 * 60 * 1000 * 1000 * 1000, 86399999999999L)
val rows = values.map(v => InternalRow(v))
val vectors = convertRows(rows, schema)
values.zipWithIndex.foreach { case (v, i) =>
assert(vectors.head.getLong(i) === v)
}
}
}

test("TimeType column with nulls") {
val schema = StructType(Seq(StructField("t", TimeType(6), nullable = true)))
val rows = Seq(
InternalRow(0L),
InternalRow(null),
InternalRow(86399999999999L))
val vectors = convertRows(rows, schema)
assert(vectors.head.getLong(0) === 0L)
assert(vectors.head.isNullAt(1))
assert(vectors.head.getLong(2) === 86399999999999L)
}

test("multiple columns") {
val schema = StructType(
Seq(StructField("s", ShortType), StructField("i", IntegerType), StructField("l", LongType)))
Expand Down