[SPARK-57174][SQL] Simplify Chr codegen by extracting a static Java helper#56224
Open
gengliangwang wants to merge 1 commit into
Open
[SPARK-57174][SQL] Simplify Chr codegen by extracting a static Java helper#56224gengliangwang wants to merge 1 commit into
gengliangwang wants to merge 1 commit into
Conversation
…elper ### What changes were proposed in this pull request? Add `ExpressionImplUtils.chr(long longVal)` and route `Chr`'s eval and codegen paths through it. `Chr.doGenCode` previously emitted a ~7-line inline if/else chain (negative -> empty string, `(v & 0xFF) == 0` -> NUL, otherwise the Latin-1 character); it now emits a single `ExpressionImplUtils.chr(...)` call, and the eval path calls the same helper. This is a plain (non-ANSI, non-try/catch) type-independent block, in line with the broadened goal of SPARK-56908 to move fixed generated-Java logic into static Java helpers. ### Why are the changes needed? Part of SPARK-56908 (umbrella). Collapsing the inline if/else chain to one call shrinks the generated Java for every stage that uses `chr`. ### Does this PR introduce _any_ user-facing change? No. The compiled behavior is identical; only the emitted Java source text changes. ### How was this patch tested? ``` build/sbt "catalyst/testOnly *StringExpressionsSuite" ``` 59/59 pass, including `string for ascii` which covers `Chr` over negative, zero, wrap-around (256), high-bit (149) and null inputs (exercised both with and without whole-stage codegen). ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8) Co-authored-by: Isaac
Contributor
|
This is a very valuable topic. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
ExpressionImplUtils.chr(long longVal)and routeChr's eval and codegen paths through it.Chr.doGenCodepreviously emitted a ~7-line inline if/else chain (negative -> empty string,(v & 0xFF) == 0-> NUL, otherwise the Latin-1 character); it now emits a singleExpressionImplUtils.chr(...)call, and the eval path calls the same helper.This is a plain (non-ANSI, non-try/catch) type-independent block, in line with the broadened goal of SPARK-56908 to move fixed generated-Java logic into static Java helpers.
Why are the changes needed?
Part of SPARK-56908 (umbrella). Collapsing the inline if/else chain to one call shrinks the generated Java for every stage that uses
chr, helping with the JVM 64KB method / constant-pool limits, Janino compile time, and JIT work.Does this PR introduce any user-facing change?
No. The compiled behavior is identical; only the emitted Java source text changes.
How was this patch tested?
59/59 pass, including
string for asciiwhich coversChrover negative, zero, wrap-around (256), high-bit (149) and null inputs (exercised both with and without whole-stage codegen).Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)