[SPARK-56244][PYTHON] Refine benchmark class layout in bench_eval_type.py#55040
Closed
Yicong-Huang wants to merge 4 commits intoapache:masterfrom
Closed
[SPARK-56244][PYTHON] Refine benchmark class layout in bench_eval_type.py#55040Yicong-Huang wants to merge 4 commits intoapache:masterfrom
Yicong-Huang wants to merge 4 commits intoapache:masterfrom
Conversation
…ault, and struct type support
zhengruifeng
approved these changes
Mar 27, 2026
Contributor
|
merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refines the benchmark class layout in
bench_eval_type.py:_scenarios,_udfs,params, andparam_names, soTime/Peakmembenchmark classes are zero-copy (pass).MockProtocolWriterandMockDataFactoryutility classes - consolidates 17 scattered module-level helper functions into two organized classes with@staticmethodmethods.Shared scenarios between related eval types (e.g., ScalarArrow/ScalarArrowIter) use inheritance rather than cross-mixin references.
Why are the changes needed?
The current layout has significant repetition: every
Time/Peakmemclass duplicates_scenarios,_udfs,params, andparam_names. Helper functions are scattered across the file with no clear organization.Does this PR introduce any user-facing change?
No
How was this patch tested?
Verified all 18 benchmark classes import correctly, have correct
params/param_names, and pass smoke tests (setup + time_worker) for every eval type.Was this patch authored or co-authored using generative AI tooling?
No