[SPARK-56242][PYTHON][TESTS] Add a test to ensure no 3rd party libraries are imported for "import pyspark"#55037
Open
gaogaotiantian wants to merge 1 commit intoapache:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
A new test is added. The new test runs
python -X importtime -c "import pyspark"to get the import dependency and checks whether 3rd party libraries are imported.Why are the changes needed?
2 weeks ago
import pysparktakes 200+ms, now it's 60ms - most of it because we lazy loadedmemory_profiler. Makeimport pysparkfast is important for user experience. It's also critical for our worker spawn time. The only way to keep it fast is to add a test to check against it.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Test passed locally.
Was this patch authored or co-authored using generative AI tooling?
No.