[SPARK-56200][CORE] Remove jackson JSON nesting depth limitation #55004
Open
lsm1 wants to merge 1 commit intoapache:masterfrom
Open
[SPARK-56200][CORE] Remove jackson JSON nesting depth limitation #55004lsm1 wants to merge 1 commit intoapache:masterfrom
lsm1 wants to merge 1 commit intoapache:masterfrom
Conversation
…tion for deep event logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR updates
JsonProtocolto remove Jackson nesting-depth limits for both reading and writing JSON, in addition to the existing string-length relaxation from SPARK-49872It also fixes serialization/deserialization paths for deep event-log JSON nodes by replacing
toString-based conversion with Jackson mapper serialization (mapper.writeValueAsString(...)) in:sparkEventFromJsonresourcesMapFromJsonThese changes make deep nested event-log payloads and resource JSON parsing more robust and consistent with Jackson serialization semantics.
Why are the changes needed?
With deeply nested JSON payloads, default Jackson stream constraints can fail with depth-limit exceptions during read/write, which can affect Spark listener event log handling.
Also, converting
JsonNodeviatoStringcan produce inconsistent behavior in some deep/complex cases. Using Jackson mapper-based serialization ensures stable JSON conversion before parsing into Spark event/resource types.Does this PR introduce any user-facing change?
Yes.
For users who have deeply nested JSON content in Spark event logs or resource-related JSON, operations that previously could fail due to Jackson depth constraints (for read/write) will now succeed. This is a behavior fix (robustness improvement), not a new API.
How was this patch tested?
No new tests were added in this patch.
Was this patch authored or co-authored using generative AI tooling?
no