Skip to content

Conversation

@mrproliu
Copy link
Contributor

@mrproliu mrproliu commented Dec 3, 2025

In the current version, range should check all the items, including, but now it's depends on the order of the range.

Such as the actual data is:

type: TIME_SERIES_VALUES
results:
  - metric:
      labels: []
    values:
      - id: "1764748320000"
        owner: null
        value: "11"
        traceid: null
      - id: "1764748380000"
        owner: null
        value: null
        traceid: null
error: null
debuggingtrace: null

The follwoing verifier will got success:

debuggingtrace: null
type: TIME_SERIES_VALUES
results:
  {{- contains .results }}
  - metric:
      labels: []
    values:
      {{- contains .values }}
      - id: {{ notEmpty .id }}
        value: {{ notEmpty .value }}
        owner: null
        traceid: null
      - id: {{ notEmpty .id }}
        value: null
        owner: null
        traceid: null
      {{- end}}
  {{- end}}
error: null

But if I change it to the following verifier, it will get an error:

debuggingtrace: null
type: TIME_SERIES_VALUES
results:
  {{- contains .results }}
  - metric:
      labels: []
    values:
      {{- contains .values }}
      - id: {{ notEmpty .id }}
        value: null
        owner: null
        traceid: null
      - id: {{ notEmpty .id }}
        value: {{ notEmpty .value }}
        owner: null
        traceid: null
      {{- end}}
  {{- end}}
error: null

Because it ranges the actual data and appends the latest check from the range verifier. So I have added a new variable to cache all the not matched data, and append them if some verifiers don't have any matches.

@mrproliu mrproliu added this to the 1.4.0 milestone Dec 3, 2025
@mrproliu mrproliu requested review from fgksgf and kezhenxu94 December 3, 2025 08:52
@mrproliu mrproliu added the bug Something isn't working label Dec 3, 2025
@mrproliu mrproliu merged commit e7138da into apache:main Dec 3, 2025
2 checks passed
@mrproliu mrproliu deleted the wrong-range-judgement branch December 3, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants