chore: Add new logs and support time format display #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR adds timestamp formatting to log output and verification messages to improve debugging and tracking capabilities.
- Enables timestamps in the logger configuration with a consistent format ("2006-01-02 15:04:05")
- Adds timestamps to verification messages to track when each verification case is processed
- Includes a debug log for trigger completion events
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/logger/log.go | Enables timestamp logging with standardized format |
| internal/components/trigger/http.go | Adds debug logging for trigger result sending; contains an unintended formatting change |
| commands/verify/verify.go | Adds timestamp formatting function and prepends timestamps to verification messages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
internal/logger/log.go
Outdated
| DisableTimestamp: true, | ||
| DisableTimestamp: false, | ||
| FullTimestamp: true, | ||
| TimestampFormat: "2006-01-02 15:04:05", |
There was a problem hiding this comment.
The timestamp format is duplicated between the logger configuration and the formatVerificationTime() function in commands/verify/verify.go. Consider defining this format as a constant in a shared location to ensure consistency and ease of maintenance.
internal/components/trigger/http.go
Outdated
| req, err := h.request() | ||
| if err != nil { | ||
| logger.Log.Errorf("failed to create new request %v", err) | ||
| logger.Log.Errorf("failed to create new request %v", err) |
There was a problem hiding this comment.
Extra space between 'request' and '%v' appears to be unintentional.
Suggested change
| logger.Log.Errorf("failed to create new request %v", err) | |
| logger.Log.Errorf("failed to create new request %v", err) |
kezhenxu94
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new logs and support time format display for troubleshooting
1、Log the trigger's final execution count and error (if any) at info level when a result is sent to the channel. This provides clear visibility into the trigger's status for troubleshooting.
2、Add formatted timestamp display to logs to help reconstruct the timeline of events for easier troubleshooting.