Skip to content

Make browser clsTime to double #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Fine0830 merged 3 commits into from
Dec 2, 2025
Merged

Make browser clsTime to double #118

Fine0830 merged 3 commits into from
Dec 2, 2025

Conversation

@wankai123
Copy link
Member

@wankai123 wankai123 commented Dec 2, 2025 •
edited
Loading

Copilot AI reviewed Dec 2, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the data type of the clsTime field in the BrowserWebVitalsPerfData protobuf message from int32 to double. This change is necessary because Cumulative Layout Shift (CLS) is a floating-point score metric, not an integer time value.

Key changes:

  • Changed clsTime field type from int32 to double in the BrowserWebVitalsPerfData message

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

browser/BrowserPerf.proto Outdated
string pagePath = 4;
// First Meaningful Paint time
int32 fmpTime = 5;
// Cumulative Layout Shift time
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment "Cumulative Layout Shift time" is misleading. CLS (Cumulative Layout Shift) is not a time metric but a dimensionless score that measures visual stability. The comment should be updated to reflect this, for example: "Cumulative Layout Shift score" or "Cumulative Layout Shift value".

Suggested change
// Cumulative Layout Shift time
// Cumulative Layout Shift score

Copilot uses AI. Check for mistakes.
@Fine0830 Fine0830 merged commit 050b6eb into master Dec 2, 2025
1 check passed
@wankai123 wankai123 deleted the browser-clstime branch December 2, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Fine0830 Fine0830 Fine0830 approved these changes

@mrproliu mrproliu Awaiting requested review from mrproliu

@wu-sheng wu-sheng Awaiting requested review from wu-sheng

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wankai123 @Fine0830