feat: update Bazel configuration and dependencies #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@wbpcode This should be mostly around C++ SDK build. PTAL. |
wbpcode
reviewed
Sep 13, 2025
Contributor
wbpcode
left a comment
wbpcode
left a comment
There was a problem hiding this comment.
LGTM overall. I am glad to see the migration to bzlmod, thanks for the contribution. Only one comment to the version.
MODULE.bazel
Outdated
| @@ -0,0 +1,9 @@ | |||
| module( | |||
| name = "skywalking-data-collect-protocol", | |||
| version = "0.0.0-dev", | |||
Contributor
There was a problem hiding this comment.
Is the version reasonable?
Contributor
Author
There was a problem hiding this comment.
That's the usual when not yet defined.
I changed it to 10.2.1-dev
After the module is integrated, it needs a workflow to publish to bcr : https://github.com/bazel-contrib/publish-to-bcr
…ibility Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Contributor
Author
|
Notice, I applied buildifer on bazel files |
Contributor
I saw it. That's fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates Bazel build configuration to use bzlmod, following https://bazel.build/external/migration . The main changes include upgrading
grpc,protobuf, andrules_proto, updating repository loading logic to avoid redundant downloads, and adjusting build files to use the updated dependency structure.