Support pprof feature #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrproliu
reviewed
Aug 6, 2025
pprof/pprof.proto
Outdated
Comment on lines
23
to
25
| option java_package = "org.apache.skywalking.apm.network.language.pprof.v10"; | ||
| option csharp_namespace = "SkyWalking.NetworkProtocol.V10"; | ||
| option go_package = "skywalking.apache.org/repo/goapi/collect/language/pprof/v10"; |
Contributor
There was a problem hiding this comment.
There should not under the language directory, please remove it.
mrproliu
reviewed
Aug 6, 2025
pprof/pprof.proto
Outdated
| } | ||
|
|
||
| message PprofData { | ||
| // metaData of the pprof task and its result data, only sent in the first request. |
Contributor
There was a problem hiding this comment.
Please format the comment.
mrproliu
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support pprof feature