feat (add profile method for go agent) #112
Merged
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrproliu
reviewed
Aug 3, 2025
Contributor
mrproliu
left a comment
mrproliu
left a comment
There was a problem hiding this comment.
Please format your code.
profile/Profile.proto
Outdated
| // check last part true or false | ||
| bool isLast = 4; | ||
| // Span IDs with duration greater than minDuration,only in the last chunk | ||
| repeated int32 spanIds=5; |
Contributor
There was a problem hiding this comment.
When do you need to use this field? Could you more explain?
profile/Profile.proto
Outdated
| // Span IDs with duration greater than minDuration,only in the last chunk | ||
| repeated int32 spanIds=5; | ||
| // use to reassemble fragments | ||
| int32 chunkId = 6; |
Contributor
There was a problem hiding this comment.
What does this field work for? You may send the profiling data without frequency, and sort by this field?
wu-sheng
reviewed
Aug 11, 2025
mrproliu
reviewed
Aug 12, 2025
profile/Profile.proto
Outdated
| } | ||
|
|
||
| // collect bytes profile data from go agent | ||
| rpc goProfileReport(stream GoProfileData)returns(Commands){} |
Contributor
There was a problem hiding this comment.
Please also format this line.
mrproliu
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.