Skip to content

[#4942] Add random time to the scheduled task for pulling instances from serviceCenter #4978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chengyouling merged 1 commit into from
Oct 11, 2025
Merged

[#4942] Add random time to the scheduled task for pulling instances from serviceCenter #4978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ...nt/src/main/java/org/apache/servicecomb/service/center/client/ServiceCenterDiscovery.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.Random;
import java.util.concurrent.ConcurrentHashMap;

import org.apache.servicecomb.http.client.task.AbstractTask;
Expand Down Expand Up @@ -101,6 +102,8 @@ public static class SubscriptionValue {

private final Object lock = new Object();

private final Random random = new Random();

public ServiceCenterDiscovery(ServiceCenterClient serviceCenterClient, EventBus eventBus) {
super("service-center-discovery-task");
this.serviceCenterClient = serviceCenterClient;
Expand Down Expand Up @@ -219,10 +222,17 @@ class PullInstanceTask implements Task {
public void execute() {
pullAllInstance();

startTask(new BackOffSleepTask(pollInterval, new PullInstanceTask()));
startTask(new BackOffSleepTask(buildPollIntervalWithSalt(), new PullInstanceTask()));
}
}

private long buildPollIntervalWithSalt() {
int positive = random.nextInt(5);
int sign = random.nextBoolean() ? 1 : -1;
long currentPollInterval = pollInterval + sign * positive * 1000;
return currentPollInterval > 0 ? currentPollInterval : pollInterval;
}

class PullInstanceOnceTask implements Task {
@Override
public void execute() {
Expand Down
Loading