Skip to content

Query counter bug fix - query counter in example server #1476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haroon3rd wants to merge 2 commits into
base: master
Choose a base branch
from
+17 −8
Open

Query counter bug fix - query counter in example server #1476

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a889b60
Refactor queryCounter to use ByteBuffer for count
haroon3rd Jun 3, 2026
f4ae140
Merge pull request #1 from haroon3rd/haroon3rd-query-counter-patch-1
haroon3rd Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions ratis-examples/src/main/java/org/apache/ratis/examples/membership/server/RaftCluster.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,15 +143,24 @@ public void counterIncrement() throws IOException {
}

public void queryCounter() throws IOException {
RaftClient client = createClient();
try {
RaftClientReply reply = client.io().sendReadOnly(CounterCommand.GET.getMessage());
String count = reply.getMessage().getContent().toStringUtf8();
System.out.println("Current counter value: " + count);
} finally {
client.close();
}
RaftClient client = createClient();

@amaliujia amaliujia Jun 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: wrong indents

try {
Comment on lines +146 to +147
RaftClientReply reply = client.io().sendReadOnly(
CounterCommand.GET.getMessage());
Comment on lines +146 to +149

ByteBuffer buffer =
reply.getMessage()
.getContent()
.asReadOnlyByteBuffer();

int count = buffer.getInt();
Comment on lines +148 to +156

System.out.println(
"Current counter value: " + count);
} finally {
client.close();
}
}

/**
* Configure the raft group with initial peers.
Expand Down