RANGER-5681: Align GDS secure download endpoint authorization with ot…#1067
Open
vyommani wants to merge 1 commit into
Open
RANGER-5681: Align GDS secure download endpoint authorization with ot…#1067vyommani wants to merge 1 commit into
vyommani wants to merge 1 commit into
Conversation
…her secure download APIs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GdsREST.getSecureServiceGdsInfoIfUpdated() (/service/gds/secure/download/{serviceName}) used a weaker validation path than the equivalent secure download endpoints for policies, roles, tags, and user-store data.
What changes were proposed in this pull request?
Replace serviceUtil.isValidateHttpsAuthentication(...) with serviceUtil.isValidService(...)
Add admin/allow-list authorization check (bizUtil.isAdmin(), bizUtil.isUserAllowed(..., Allowed_User_List_For_Download / Allowed_User_List_For_Grant_Revoke)), matching ServiceREST.getSecureServicePoliciesIfUpdated()
Return 403 when the caller isn't admin or allow-listed for the service
How was this patch tested?
Updated TestGdsREST with coverage for admin, allow-listed non-admin, and forbidden non-admin paths
Verified live: low-privileged authenticated user now gets 403 (was 200); admin and allow-listed users still get 200; sibling policy-download endpoint behavior unaffected (control)