Skip to content

Conversation

@guptas6est
Copy link
Contributor

Motivation

This PR addresses multiple CVEs detected in transitive dependencies used in the Pulsar IO module flume.
The affected libraries are Apache Tomcat Embed Core, Apache MINA and Apache Derby, which were introducing vulnerabilities through indirect dependencies.

Vulnerabilities remediated include:

Apache Tomcat Embed Core

Apache MINA

Apache Derby

Modifications

Added exclusions for vulnerable transitive dependencies in:

  • pulsar-io/flume/pom.xml → Excluded tomcat-embed-core and derby and override mina-core

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: Nordix#10
(See the second-last commit for the GitHub Actions results.)

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 5, 2025
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and putting effort in resolving CVEs, @guptas6est.

One challenge is that the tests for Pulsar IO Flume connector don't currently contain end-to-end tests and only use an in-memory channel solution. Since Apache Flume isn't maintained anymore ("This project is not maintained anymore!" at https://flume.apache.org/, I think that this is a sufficient solution. There's no need to add additional tests.

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.22%. Comparing base (c4f125c) to head (a9f10a9).
⚠️ Report is 24 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #24949       +/-   ##
=============================================
+ Coverage     38.77%   74.22%   +35.45%     
- Complexity    13380    33888    +20508     
=============================================
  Files          1856     1913       +57     
  Lines        145342   149505     +4163     
  Branches      16886    17372      +486     
=============================================
+ Hits          56353   110975    +54622     
+ Misses        81459    29671    -51788     
- Partials       7530     8859     +1329     
Flag Coverage Δ
inttests 26.44% <ø> (+0.03%) ⬆️
systests 22.70% <ø> (-0.15%) ⬇️
unittests 73.75% <ø> (+38.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1411 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari added this to the 4.2.0 milestone Nov 6, 2025
@lhotari lhotari merged commit 39aeec5 into apache:master Nov 6, 2025
54 checks passed
lhotari pushed a commit that referenced this pull request Nov 11, 2025
…ide mina-core to remediate CVEs (#24949)

(cherry picked from commit 39aeec5)
lhotari pushed a commit that referenced this pull request Nov 11, 2025
…ide mina-core to remediate CVEs (#24949)

(cherry picked from commit 39aeec5)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 13, 2025
…ide mina-core to remediate CVEs (apache#24949)

(cherry picked from commit 39aeec5)
(cherry picked from commit e665b94)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 14, 2025
…ide mina-core to remediate CVEs (apache#24949)

(cherry picked from commit 39aeec5)
(cherry picked from commit e665b94)
@lhotari
Copy link
Member

lhotari commented Dec 16, 2025

Removing Flume connector in #25079

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants