-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][sec] Added Exclusions for tomcat-embed-core and derby and override mina-core to remediate CVEs #24949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ide mina-core to remediate CVEs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and putting effort in resolving CVEs, @guptas6est.
One challenge is that the tests for Pulsar IO Flume connector don't currently contain end-to-end tests and only use an in-memory channel solution. Since Apache Flume isn't maintained anymore ("This project is not maintained anymore!" at https://flume.apache.org/, I think that this is a sufficient solution. There's no need to add additional tests.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24949 +/- ##
=============================================
+ Coverage 38.77% 74.22% +35.45%
- Complexity 13380 33888 +20508
=============================================
Files 1856 1913 +57
Lines 145342 149505 +4163
Branches 16886 17372 +486
=============================================
+ Hits 56353 110975 +54622
+ Misses 81459 29671 -51788
- Partials 7530 8859 +1329
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…ide mina-core to remediate CVEs (apache#24949) (cherry picked from commit 39aeec5) (cherry picked from commit e665b94)
…ide mina-core to remediate CVEs (apache#24949) (cherry picked from commit 39aeec5) (cherry picked from commit e665b94)
|
Removing Flume connector in #25079 |
Motivation
This PR addresses multiple CVEs detected in transitive dependencies used in the Pulsar IO module flume.
The affected libraries are Apache Tomcat Embed Core, Apache MINA and Apache Derby, which were introducing vulnerabilities through indirect dependencies.
Vulnerabilities remediated include:
Apache Tomcat Embed Core
Apache MINA
Apache Derby
Modifications
Added exclusions for vulnerable transitive dependencies in:
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: Nordix#10
(See the second-last commit for the GitHub Actions results.)