Open
Conversation
8a36d3d to
dd2bd5e
Compare
mdedetrich
commented
Oct 24, 2024
| Unmarshal(request.entity).to[FcmSend].futureValue shouldBe FcmSend(false, FcmNotification.empty) | ||
| request.uri.toString should startWith("https://fcm.googleapis.com/v1/projects/projectId/messages:send") | ||
| request.headers.size shouldBe 1 | ||
| request.headers.size shouldBe 2 |
Contributor
Author
There was a problem hiding this comment.
Since we have added an extra keep alive header we know return 2 headers, but we still only check the first header for what we expect
f6e594f to
19fa066
Compare
19fa066 to
2da9fb6
Compare
Contributor
Author
|
I have rebased the PR against latest main and set milestone to 1.1.2 as I don't have the ability to properly test this any time soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So when trying to upload a file to google cloud storage I received the following error
I did some reading at googleapis/nodejs-storage#101 (comment) and https://pekko.apache.org/docs/pekko-http/current/configuration.html, my current theory is that we need to make sure that both the connection pool has its keep alive timeout set to infinity and any requests using the
Connection: Keep Aliveheader explicitly@raboof @jrudolph Would be good if you manage to look into this, I am not 100% sure that this will actually solve the underlying issue, its just based off of what I could find on the internet.