Skip to content

close document in PDFCloneUtilityTest.testClonePDFWithCosArrayStream2 #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
valerybokov wants to merge 1 commit into from
Closed

close document in PDFCloneUtilityTest.testClonePDFWithCosArrayStream2 #415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 48 additions & 46 deletions pdfbox/src/test/java/org/apache/pdfbox/multipdf/PDFCloneUtilityTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,54 +86,56 @@ void testClonePDFWithCosArrayStream2() throws IOException

new File(TESTDIR).mkdirs();

PDDocument srcDoc = new PDDocument();
PDPage pdPage = new PDPage();
srcDoc.addPage(pdPage);
try (PDPageContentStream pdPageContentStream1 = new PDPageContentStream(srcDoc, pdPage, AppendMode.APPEND, false))
try(PDDocument srcDoc = new PDDocument())
{
pdPageContentStream1.setNonStrokingColor(Color.black);
pdPageContentStream1.addRect(100, 600, 300, 100);
pdPageContentStream1.fill();
}
try (PDPageContentStream pdPageContentStream2 = new PDPageContentStream(srcDoc, pdPage, AppendMode.APPEND, false))
{
pdPageContentStream2.setNonStrokingColor(Color.red);
pdPageContentStream2.addRect(100, 500, 300, 100);
pdPageContentStream2.fill();
}
try (PDPageContentStream pdPageContentStream3 = new PDPageContentStream(srcDoc, pdPage, AppendMode.APPEND, false))
{
pdPageContentStream3.setNonStrokingColor(Color.yellow);
pdPageContentStream3.addRect(100, 400, 300, 100);
pdPageContentStream3.fill();
}
PDPage pdPage = new PDPage();
srcDoc.addPage(pdPage);
try (PDPageContentStream pdPageContentStream1 = new PDPageContentStream(srcDoc, pdPage, AppendMode.APPEND, false))
{
pdPageContentStream1.setNonStrokingColor(Color.black);
pdPageContentStream1.addRect(100, 600, 300, 100);
pdPageContentStream1.fill();
}
try (PDPageContentStream pdPageContentStream2 = new PDPageContentStream(srcDoc, pdPage, AppendMode.APPEND, false))
{
pdPageContentStream2.setNonStrokingColor(Color.red);
pdPageContentStream2.addRect(100, 500, 300, 100);
pdPageContentStream2.fill();
}
try (PDPageContentStream pdPageContentStream3 = new PDPageContentStream(srcDoc, pdPage, AppendMode.APPEND, false))
{
pdPageContentStream3.setNonStrokingColor(Color.yellow);
pdPageContentStream3.addRect(100, 400, 300, 100);
pdPageContentStream3.fill();
}

srcDoc.save(TESTDIR + CLONESRC);
PDFMergerUtility merger = new PDFMergerUtility();
try (PDDocument dstDoc = new PDDocument())
{
// this calls PDFCloneUtility.cloneForNewDocument(),
// which would fail before the fix in PDFBOX-2052
merger.appendDocument(dstDoc, srcDoc);

// save and reload PDF, so that one can see that the files are legit
dstDoc.save(TESTDIR + CLONEDST);
}
try (PDDocument doc = Loader.loadPDF(new File(TESTDIR + CLONESRC)))
{
assertEquals(1, doc.getNumberOfPages());
}
try (PDDocument doc = Loader.loadPDF(new File(TESTDIR + CLONESRC), (String) null))
{
assertEquals(1, doc.getNumberOfPages());
}
try (PDDocument doc = Loader.loadPDF(new File(TESTDIR + CLONEDST)))
{
assertEquals(1, doc.getNumberOfPages());
}
try (PDDocument doc = Loader.loadPDF(new File(TESTDIR + CLONEDST), (String) null))
{
assertEquals(1, doc.getNumberOfPages());
srcDoc.save(TESTDIR + CLONESRC);
PDFMergerUtility merger = new PDFMergerUtility();
try (PDDocument dstDoc = new PDDocument())
{
// this calls PDFCloneUtility.cloneForNewDocument(),
// which would fail before the fix in PDFBOX-2052
merger.appendDocument(dstDoc, srcDoc);

// save and reload PDF, so that one can see that the files are legit
dstDoc.save(TESTDIR + CLONEDST);
}
try (PDDocument doc = Loader.loadPDF(new File(TESTDIR + CLONESRC)))
{
assertEquals(1, doc.getNumberOfPages());
}
try (PDDocument doc = Loader.loadPDF(new File(TESTDIR + CLONESRC), (String) null))
{
assertEquals(1, doc.getNumberOfPages());
}
try (PDDocument doc = Loader.loadPDF(new File(TESTDIR + CLONEDST)))
{
assertEquals(1, doc.getNumberOfPages());
}
try (PDDocument doc = Loader.loadPDF(new File(TESTDIR + CLONEDST), (String) null))
{
assertEquals(1, doc.getNumberOfPages());
}
}
}

Expand Down