[lumina] Use VECTOR length for index dimension#8235
Open
QuakeWang wants to merge 1 commit into
Open
Conversation
Lumina vector writers previously used lumina.index.dimension for both ARRAY and VECTOR fields. For VECTOR fields this could fall back to the default dimension even though the schema already carries the fixed length, causing write validation and index metadata to disagree with the actual field type. Resolve the effective dimension from VECTOR length, reject explicit dimension conflicts, and build native Lumina options from that resolved dimension so PQ options are capped against the real dimension. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Lumina vector writers used
lumina.index.dimensionfor both ARRAY and VECTOR fields. For VECTOR fields, the schema already carries the fixed length, so falling back to the default dimension could make write validation and index metadata disagree with the actual field type.This PR resolves the effective dimension from
VectorType#getLength(), rejects explicit dimension conflicts, and builds native Lumina options from the resolved dimension so PQ options are capped against the real dimension.ArrayType<FLOAT>continues to uselumina.index.dimension.Tests
mvn -pl paimon-lumina -am -DfailIfNoTests=false -Dtest=LuminaVectorGlobalIndexWriterTest,LuminaVectorOptionsTest test