Skip to content

[core] Reuse manifest merge results on commit retry#8229

Draft
leaves12138 wants to merge 1 commit into
apache:masterfrom
leaves12138:codex/reuse-manifest-merge-on-retry
Draft

[core] Reuse manifest merge results on commit retry#8229
leaves12138 wants to merge 1 commit into
apache:masterfrom
leaves12138:codex/reuse-manifest-merge-on-retry

Conversation

@leaves12138

Copy link
Copy Markdown
Contributor

Summary

  • Reuse the previous manifest merge result on commit retry when all previously merged input manifests still exist in the latest snapshot.
  • Replace those input manifests in the latest manifest list with the merged output manifests, preserving concurrent manifests and falling back to a fresh merge if any input manifest disappeared.
  • Always write a fresh base manifest list for the retry commit so no base manifest list file is reused across attempts.
  • Add retry conflict tests for contiguous, non-contiguous, missing-before, multi-retry, empty-table, and delete-order cases.

Tests

  • mvn -pl paimon-core -Pfast-build -Dtest=FileStoreCommitTest#testCommitRetryReusePreviousManifestMergeResultWhenBeforeStillExists+testCommitRetryReusePreviousManifestMergeResultWhenBeforeExistsNonContiguously+testCommitRetryDoesNotReusePreviousManifestMergeResultWhenBeforeWasMerged+testCommitRetryReusePreviousManifestMergeResultAcrossMultipleRetries+testCommitRetryFromEmptyTableWithConcurrentFirstSnapshot+testCommitRetryReusePreviousManifestMergeResultPreservesDeleteOrder test
  • mvn -pl paimon-core -Pfast-build -Dtest=FileStoreCommitTest test
  • mvn -pl paimon-core -DskipTests compile
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant