[core][flink] Support view operations in JDBC Catalog#8208
Open
tchivs wants to merge 2 commits into
Open
Conversation
- Add view methods to CachingCatalog for proper delegation - Add IT tests for JDBC Catalog view operations - Add SQLite JDBC dependency for tests
Author
|
@JingsongLi I pushed a follow-up commit to address the old review questions from #6667 and a few local review edge cases. PTAL when you have time. What changed:
Local validation:
I also retried |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revives #6667 and ports the JDBC catalog view support onto current
master.Hi @JingsongLi, I addressed the questions from the previous review in #6667:
paimon_views.It stores
(catalog_key, database_name, view_name, view_schema)with a primary key on the catalog/database/view tuple.ViewSchema; the JDBC catalog does not parse or resolve the SQL text duringcreateView.createViewcoverage relying on the JDBC primary key constraint.ViewChangeAPI andlistViewDetailsPagedfallback.Validation:
git diff --checkmvn -pl paimon-core spotless:checkmvn -pl paimon-core -am -Pfast-build -DfailIfNoTests=false -Dtest=JdbcCatalogTest testJdbcCatalogTestran 62 tests, 0 failures, 0 errors.I also attempted:
mvn -pl paimon-flink/paimon-flink-common -am -Pfast-build -DfailIfNoTests=false -Dtest=JdbcCatalogViewITCase testThat command was blocked before test execution by dependency resolution timeout from
https://jindodata-binary.oss-cn-shanghai.aliyuncs.com/mvn-repo/forcom.aliyun.jindodata:jindo-core:6.9.1andjindo-sdk:6.9.1while building unrelatedpaimon-jindo.