test(datafusion): cover SQL schema evolution reads#391
Open
liujiwen-up wants to merge 1 commit into
Open
Conversation
QuakeWang
reviewed
Jun 17, 2026
| ctx.sql(sql).await?.collect().await | ||
| } | ||
|
|
||
| async fn assert_sql(sql: &str, expected: &[&str]) { |
Member
There was a problem hiding this comment.
Nit: this helper compares the full pretty_format_batches output verbatim. It keeps the expected SQL result readable, but also couples the tests to Arrow/DataFusion pretty-printer details such as padding, borders, and NULL rendering. Fine for these small result sets; if we want less brittle tests across dependency upgrades, comparing normalized rows/columns would be more stable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #258
Add DataFusion SQL coverage for schema evolution tables generated from Java/Spark consistency fixtures, focusing on mixed-format reads through SQL. The rename coverage uses
schema_evolution_rename_column, whose fixture contains parquet/orc/avro files.Brief change log
assert_sqlhelper for table-formatted SQL result assertions.SELECT,WHERE, andORDER BY id.Tests
cargo fmt --check: passedgit diff --check: passedcargo test -p paimon-datafusion --test read_tables schema_evolution --no-run: passedcargo test -p paimon-datafusion --test read_tables schema_evolution -- --nocapture: not fully runnable locally because/tmp/paimon-warehousehas not been provisioned and Docker daemon is unavailableAPI and Format
No API or storage format changes.
Documentation
No documentation changes required.