fix: support missing columns in Mosaic reads#389
Merged
Conversation
Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #378
Mosaic reads used to validate the full requested schema before checking the physical Mosaic file schema. When a requested column was missing from an older Mosaic file, an unsupported type in that missing column could fail the read before
DataFileReaderhad a chance to fill it with nulls.Brief change log
DataFileReader.DataFileReadertest covering null fill for a physically missing Mosaic column.Tests
cargo fmt --all -- --checkcargo test -p paimon --features mosaic arrow::format::mosaic -- --nocapturecargo test -p paimon --features mosaic table::data_file_reader -- --nocapturecargo check -p paimon-datafusion --features mosaiccargo clippy -p paimon --features mosaic --tests -- -D warningsAPI and Format
Documentation