feat(datafusion): consolidate DML WriteBuilder usage#384
Open
QuakeWang wants to merge 1 commit into
Open
Conversation
Create one WriteBuilder for append-only MERGE INTO attempts and use it for not-matched inserts and the final commit. Document the current DataFusion DML support matrix and add regression coverage for unsupported UPDATE, DELETE, and MERGE INTO cases. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #232
DataFusion DML already had table write/update paths, but append-only MERGE INTO still created write and commit builders at separate call sites, and the supported/unsupported DML boundaries were not documented clearly. This made the WriteBuilder integration look incomplete and left primary-key row-level DML easy to misinterpret as supported.
Brief change log
WriteBuilderacross append-only CoW MERGE INTO not-matched inserts and the final commit.CopyOnWriteMergeWriterresponsible for CoW rewrites instead of exposing it through the public builder API.Tests
cargo fmt --all -- --checkcargo clippy --all-targets --workspace --features fulltext,vortex -- -D warningscargo test -p paimon-datafusion --test update_tests --test delete_tests --test merge_into_tests --test append_merge_intoAPI and Format
No public API or storage format changes.
Documentation
Updated
docs/src/sql.mdwith the DataFusion DML support matrix.