Skip to content

HDDS-14775. Check leader status before serving bootstrap request. #9873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sadanand48 wants to merge 3 commits into
base: master
Choose a base branch
from
+33 −0
Draft

HDDS-14775. Check leader status before serving bootstrap request. #9873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21b1b4e
HDDS-14775. Check leader status before serving bootstrap request.
Mar 6, 2026
3a613b9
use leaderReady
Mar 6, 2026
f03dcb8
unused imports
Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ...p-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMDBCheckpointServlet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
import java.util.stream.Stream;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.apache.commons.compress.archivers.ArchiveOutputStream;
import org.apache.commons.compress.archivers.tar.TarArchiveEntry;
import org.apache.commons.io.FileUtils;
Expand Down Expand Up @@ -133,6 +134,25 @@ public void init() throws ServletException {
lock = new Lock(om);
}

@Override
public void processMetadataSnapshotRequest(HttpServletRequest request, HttpServletResponse response,
boolean isFormData, boolean flush) {
OzoneManager om = (OzoneManager) getServletContext().getAttribute(OzoneConsts.OM_CONTEXT_ATTRIBUTE);
boolean isOmLeader = om.isLeaderReady();
if (!isOmLeader) {
String msg = "Unable to process metadata snapshot request as this OM is not the leader";
LOG.warn(msg);
try {
response.sendError(HttpServletResponse.SC_SERVICE_UNAVAILABLE, msg);
} catch (IOException e) {
LOG.warn("Failed to send error response, falling back to status only", e);
response.setStatus(HttpServletResponse.SC_SERVICE_UNAVAILABLE);
}
return;
}
super.processMetadataSnapshotRequest(request, response, isFormData, flush);
}

@Override
public void writeDbDataToStream(DBCheckpoint checkpoint,
HttpServletRequest request,
Expand Down
13 changes: 13 additions & 0 deletions ...manager/src/main/java/org/apache/hadoop/ozone/om/OMDBCheckpointServletInodeBasedXfer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,19 @@ public BootstrapStateHandler.Lock getBootstrapStateLock() {
@Override
public void processMetadataSnapshotRequest(HttpServletRequest request, HttpServletResponse response,
boolean isFormData, boolean flush) {
OzoneManager om = (OzoneManager) getServletContext().getAttribute(OzoneConsts.OM_CONTEXT_ATTRIBUTE);
boolean isOmLeader = om.isLeaderReady();
if (!isOmLeader) {
String msg = "Unable to process metadata snapshot request as this OM is not the leader";
LOG.warn(msg);
try {
response.sendError(HttpServletResponse.SC_SERVICE_UNAVAILABLE, msg);
} catch (IOException e) {
LOG.warn("Failed to send error response, falling back to status only", e);
response.setStatus(HttpServletResponse.SC_SERVICE_UNAVAILABLE);
}
return;
}
String[] sstParam = isFormData ?
parseFormDataParameters(request) : request.getParameterValues(
OZONE_DB_CHECKPOINT_REQUEST_TO_EXCLUDE_SST);
Expand Down