HDDS-14772. Delete EC replica when container state is already DELETED.#9872
Open
ashishkumar50 wants to merge 3 commits intoapache:masterfrom
Open
HDDS-14772. Delete EC replica when container state is already DELETED.#9872ashishkumar50 wants to merge 3 commits intoapache:masterfrom
ashishkumar50 wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
|
This change makes sense, as if all other replicas of an EC container are deleted, retaining a lagging deleted one cannot help for dataloss scenarios like with a Ratis container. Is there a unit test that covers checking the delete command is actually sent? From the test changes in the PR I was not sure if it is covered or not. |
Contributor
Author
Added a new test to cover this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When an EC container is already DELETED, and if any replica reports to SCM after that SCM can delete that replica. This will reduce orphan EC replica present in the system.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14772
How was this patch tested?
Update existing test