HDDS-14768. Fix lock leak during snapshot cache cleanup and handle eviction race appropriately.#9869
Open
SaketaChalamchala wants to merge 2 commits intoapache:masterfrom
Open
HDDS-14768. Fix lock leak during snapshot cache cleanup and handle eviction race appropriately.#9869SaketaChalamchala wants to merge 2 commits intoapache:masterfrom
SaketaChalamchala wants to merge 2 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently,
IllegalStateExceptionwhen it finds stale entries inpendingEvictionQueuefor snapshots that have already been removed from dbMapEx., say SnapshotPurge invalidates the entry right before the last thread with a reference to the snapshot just closes adding the snapshotID back to the evictionQueue
invalidateremoves snapshot entry from dbMap but does not remove it frompendingEvictionQueueif it exists.dbMapunlesssome other thread explicitly invalidates it or references it again. This means
SnapshotCache.lock()during this time cannot hold the write lock becauselock()expects the cache to be drained.cleanup(true)throws an exception write lock is not released inSnapshotCache.lock()Proposed solution:
SnapshotCache.lock()What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14768
(Please replace this section with the link to the Apache JIRA)
How was this patch tested?
Unit tests.