HDDS-14718. Update Remaining Allocatable to consider Free Space To Spare#9826
HDDS-14718. Update Remaining Allocatable to consider Free Space To Spare#9826ssulav wants to merge 7 commits intoapache:masterfrom
Conversation
sreejasahithi
left a comment
sreejasahithi
left a comment
There was a problem hiding this comment.
Thanks @ssulav for fixing this.
...cli-admin/src/test/java/org/apache/hadoop/hdds/scm/cli/datanode/TestUsageInfoSubcommand.java
Outdated
Show resolved
Hide resolved
siddhantsangwan
left a comment
siddhantsangwan
left a comment
There was a problem hiding this comment.
Just one comment below.
| info.getRemainingAllocatable() + " B", | ||
| StringUtils.byteDesc(info.getRemainingAllocatable())); |
There was a problem hiding this comment.
To make it even easier to understand for the user, we can add the formula used for calculating remainingAllocatable as a helpful string in brackets. Some of the fields above are doing the same.
There was a problem hiding this comment.
Added. Please review again
There was a problem hiding this comment.
Should we rename Container Pre Allocated to Committed? Or else use Container Pre allocated in the help string.
There was a problem hiding this comment.
Best to check what recon and other places are using and use the same name consistently everywhere.
|
@ssulav There's a checkstyle failure, you'll need to split the line to multiple lines. |
|
Created https://issues.apache.org/jira/browse/HDDS-14774 for the CI failure. Rerunning it now. |
3 participants
What changes were proposed in this pull request?
In the datanode usgae info, update Remaining Allocatable to also consider Free Space To Spare.
Right now, it is showing the capacity only in the allocatable which is not totally true, as min free space to spare should be excluded.
What is the link to the Apache JIRA
HDDS-14718
How was this patch tested?
It is to be tested manually.