Skip to content

HDDS-14708. Move server code out of ozone-common#9821

Open
adoroszlai wants to merge 2 commits intoapache:masterfrom
adoroszlai:HDDS-14708
Open

HDDS-14708. Move server code out of ozone-common#9821
adoroszlai wants to merge 2 commits intoapache:masterfrom
adoroszlai:HDDS-14708

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

  • Classes in org.apache.hadoop.ozone.om.lock are not for clients, so should be moved to ozone-interface-storage (where OMMetadataManager uses some of them).
  • Classes org.apache.hadoop.ozone.om.S3Secret* are used only in ozone-manager, move to that module.
  • Adjust dependencies accordingly.

https://issues.apache.org/jira/browse/HDDS-14708

How was this patch tested?

https://github.com/adoroszlai/ozone/actions/runs/22364980180

@adoroszlai
Copy link
Contributor Author

@sadanand48 please take a look

@sodonnel
Copy link
Contributor

sodonnel commented Mar 6, 2026

There is no logic change here, so I am fine with it. I just worry about these reorganizations from a backport perspective, as it can make them more difficult. That said, we cannot prevent any code improvements just to make backports easier.

+1 from me for the change with the above in mind.

Copy link
Contributor

@ivandika3 ivandika3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. Overall looks good.

I recall that the interface-storage module is used to separate storage and RPC proto (HDDS-4216).

In this case, should we instead move them to the ozone-manager module instead?

@adoroszlai
Copy link
Contributor Author

In this case, should we simply move them to the ozone-manager module instead?

OMMetadataManager, defined in interface-storage, uses some of the lock interfaces, which in turn use other types from the ....om.lock package. Moved the rest to ozone-manager.

@adoroszlai adoroszlai requested a review from ivandika3 March 7, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants