HDDS-13919. S3 Conditional Writes (PutObject) [3/3] - Remove expectedETag from OmKeyInfo#10182
Merged
peterxcli merged 3 commits intoapache:masterfrom May 4, 2026
Conversation
Signed-off-by: peterxcli <peterxcli@gmail.com>
Member
Author
|
cc @YutaLin |
Signed-off-by: peterxcli <peterxcli@gmail.com>
ivandika3
approved these changes
May 4, 2026
Contributor
ivandika3
left a comment
There was a problem hiding this comment.
Thanks @peterxcli , LGTM +1.
Member
Author
|
Thanks @ivandika3 for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Found this while i was reviewing #10181
If-Match is handled on create using only
KeyArgs:validateAndRewriteIfMatchAsExpectedGenerationchecks the ETag against the DB key, then folds that intoexpectedDataGenerationand clearsKeyArgs.expectedETagbeforeprepareFileInfo. SoOmKeyInfonever needed to carry the ETag; commit validation usesexpectedDataGenerationonly (seevalidateAtomicRewriteinOMKeyCommitRequest). The tests were already assertingopenKeyInfo.getExpectedETag() == null.What is the link to the Apache JIRA
How was this patch tested?
existing tests