ORC-1822: [C++][CI] Use cpp-linter-action for clang-tidy and clang-format #2077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
According to the PR status, I converted this to Please let me know when it's ready~ |
Member
Author
|
Thanks @dongjoon-hyun! Since https://issues.apache.org/jira/browse/INFRA-26318 has been resolved, let me revive this PR. |
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
CI seems to pass. Is this PR ready to go, @wgtmac ?
Member
Author
|
No, I still hit the permission error. I need some time to investigate. |
Member
|
Thank you always, @wgtmac . And, congratulations for your new Arrow PMC role. You must be busier than before. 😄 |
Member
Author
|
Thank you very much, @dongjoon-hyun! Yes, I cannot be any busier now :) |
Member
Author
|
It works now! @dongjoon-hyun @ffacs |
wgtmac
changed the title
Member
|
Merged to main for Apache ORC 2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use the GitHub cpp-linter-action to report clang-tidy/clang-format issues directly on the pull request.
Why are the changes needed?
It is much easier to use and more user-friendly.
How was this patch tested?
Pass CIs. I have also manually tested that it can report the issues.
Was this patch authored or co-authored using generative AI tooling?
No.