Skip to content

fix: ETCD volume size was not usin corresponding env variable if passsed #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Sep 24, 2025
+10 −4
Merged

fix: ETCD volume size was not usin corresponding env variable if passsed #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aadb92e
fix: ETCD volume size was not usin corresponding env variable if passsed
francescotimperioss Sep 24, 2025
9c3a7cf
chore: added a parameter to cusotmize the milvus S3 bucket size
francescotimperioss Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions deploy/nuvolaris-permissions/whisk-crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ spec:
type: boolean
seaweedfs:
description: deploys an S3 compatible layer using a standalone deployment of seaweedfs
type: boolean
type: boolean
required:
- openwhisk
- couchdb
Expand Down Expand Up @@ -754,10 +754,11 @@ spec:
type: integer
ledgers:
description: pulsar bookie ledgers instance volume size
type: integer
type: integer
bucket:
description: used to setup a quota on the S3 bucket when running under seaweedfs (default to 10240MB)
type: integer
type: integer
replicas:
description: number of total milvus replicas. Defaulted to 1
type: integer
Expand Down Expand Up @@ -997,4 +998,9 @@ spec:
type: string
priority: 0
jsonPath: .status.whisk_create.registry
description: Registry
description: Registry
- name: Seaweedfs
type: string
priority: 0
jsonPath: .status.whisk_create.seaweedfs
description: Seaweedfs
2 changes: 1 addition & 1 deletion nuvolaris/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,7 +761,7 @@ def get_etcd_config_data():
"applypodsecurity":get_enable_pod_security(),
"name": "nuvolaris-etcd",
"container": "nuvolaris-etcd",
"size": cfg.get("etcd.volume-size", "REDIS_VOLUME_SIZE", 5),
"size": cfg.get("etcd.volume-size", "STORAGE_SIZE_ETCD", 5),
"storageClass": cfg.get("nuvolaris.storageclass"),
"root_password":cfg.get("etcd.root.password") or "s0meP@ass3wd",
"etcd_replicas":get_etcd_replica(),
Expand Down
Loading