[OLINGO-1501] Fix error when OData client receives EdmDateTime or EdmDateTimeOffset values with precision greater than milliseconds#54
Open
nmiguezg wants to merge 1 commit intoapache:masterfrom
Conversation
065b18c to
8699c8a
Compare
…DateTimeOffset values with precision greater than milliseconds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the client library reads a query payload in Atom format containing values of type EdmDateTime or EdmDateTimeOffset with a precision greater than milliseconds, it throws an EdmSimpleTimeException, causing the entire query to fail.
According to the OData 2.0 standard specification (OData 2.0 Overview, section 6. Primitive Data Types), literals of type EdmDateTime and EdmDateTimeOffset support up to seven decimal places of precision:
So, here it is fixed by changing both date types default type from
java.util.Calendartojava.sql.Timestamp(as it's also the default type in the olingo-odata4 library).