Skip to content

drivers/contactless: fix uninitialized uid leak in mfrc522_read #19419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaoxiang781216 merged 1 commit into from
Jul 13, 2026
+8 −1
Merged

drivers/contactless: fix uninitialized uid leak in mfrc522_read #19419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion drivers/contactless/mfrc522.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1480,6 +1480,7 @@ static ssize_t mfrc522_read(FAR struct file *filep, FAR char *buffer,
FAR struct inode *inode;
FAR struct mfrc522_dev_s *dev;
FAR struct picc_uid_s uid;
int ret;

inode = filep->f_inode;

Expand All @@ -1496,7 +1497,13 @@ static ssize_t mfrc522_read(FAR struct file *filep, FAR char *buffer,

/* Now read the UID */

mfrc522_picc_select(dev, &uid, 0);
memset(&uid, 0, sizeof(uid));
ret = mfrc522_picc_select(dev, &uid, 0);
if (ret < 0)
{
ctlserr("Failed to select PICC: %d\n", ret);
return ret;
}

if (uid.sak != PICC_TYPE_NOT_COMPLETE)
{
Expand Down
Loading