Skip to content

sched/task: fix nxtask_exit() freeing the wrong TCB on non-SMP (#19308) #19398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
94xhn wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −3
Open

sched/task: fix nxtask_exit() freeing the wrong TCB on non-SMP (#19308) #19398

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions sched/task/task_exit.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,14 +77,18 @@ int nxtask_exit(void)
FAR struct tcb_s *dtcb;
FAR struct tcb_s *rtcb;
int ret;
#ifdef CONFIG_SMP
/* Avoid using this_task() because it may assume a state that is not
* appropriate for an exiting task.
* appropriate for an exiting task: if a higher-priority task became
* ready and was placed at the head of the ready-to-run list while
* the context switch away from the exiting task is still deferred,
* this_task() (the ready-to-run head) no longer identifies the task
* that is actually exiting.
*/

#ifdef CONFIG_SMP
dtcb = current_task(this_cpu());
#else
dtcb = this_task();
dtcb = g_running_tasks[this_cpu()];

@hujun260 hujun260 Jul 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed you replaced this_task() with g_running_tasks[this_cpu()]. Could you explain under what circumstances these two might not be equal in nxtask_exit?

#endif

sinfo("%s pid=%d,TCB=%p\n", get_task_name(dtcb),
Expand Down
Loading